chore: upgrade spack-packages to v2025.11.0 by wdconinc · Pull Request #35 · eic/containers

wdconinc · 2025-11-15T00:49:58Z

Briefly, what does this PR introduce?

Needs:

~~chore: upgrade spack to v1.1.0 #34 (not really but that one includes some hinting that should apply here too)~~
Alternatively:
feat: better resilience against listing already included cherry-picks #101
fix: yoda: require: @2.1.0: #105

This PR upgrades spack-packages to v2025.11.0, https://github.com/spack/spack-packages/releases/tag/v2025.11.0.

What kind of change does this PR introduce?

Bug fix (issue #__)
New feature (issue #__)
Documentation update
Other: __

Please check if this PR fulfills the following:

Tests for the changes have been added
Documentation has been added / updated
Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

Copilot

Pull Request Overview

This PR upgrades the spack-packages dependency from v2025.07.0 to v2025.11.0, removing the need for previously cherry-picked commits that are now included in the new release.

Updated SPACKPACKAGES_VERSION to v2025.11.0
Cleared all cherry-picked commits as they are now part of the base release
Removed associated cherry-pick file mappings and descriptive comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

containers/debian/Dockerfile

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

spack-packages.sh

spack-environment/xl/spack.yaml

spack-environment/packages.yaml

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

spack-environment/ci_without_acts/spack.yaml

spack-environment/ci/spack.yaml

spack-environment/cvmfs/spack.yaml

…h cairo dependency

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…(& req for pango)

.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This reverts commit 868c506.

…aarch64

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

spack-environment/packages.yaml

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

spack-environment/packages.yaml

wdconinc · 2025-12-30T18:52:35Z

Comparison:

12:40:34 wdconinc@menelaos ~ $ docker run --rm -it ghcr.io/eic/eic_ci:nightly bash -c 'du -sh /opt/software/linux-*/* | sort -h | tail'
115M    /opt/software/linux-x86_64_v2/py-scipy-1.16.0-3h37q7xry2ky3ldgqmqpcp7uqiunzmqp
123M    /opt/software/linux-x86_64_v2/pythia8-8.315-vyooop3m72kizt5ddnwts24j3zfhqzvm
128M    /opt/software/linux-x86_64_v2/g4realsurface-2.2-7pbzz3kycww3u7airf7r42d22wpxhfhg
133M    /opt/software/linux-x86_64_v2/git-2.48.1-75ehiolr7t2p3lqhvf6hkeb6tzusrof2
229M    /opt/software/linux-x86_64_v2/boost-1.88.0-hlidzutmz7uplxqoaa6tmfnz2tiuvcz5
235M    /opt/software/linux-x86_64_v2/geant4-11.3.2.east-6vuzwbahjodkkxpgwwhcfkpca2ctb6ja
316M    /opt/software/linux-x86_64_v2/python-3.13.5-imu4nycwgxq6f6ffns2xjdmvyb7x5xal
347M    /opt/software/linux-x86_64_v2/arrow-19.0.1-5zb2q4zzmcrcodmjyrmgq52okpd3uscc
520M    /opt/software/linux-x86_64_v2/root-6.38.00-447she4aapomzvbv6woowvin7twkct2e
681M    /opt/software/linux-x86_64_v2/g4emlow-8.6.1-kwc7wum5crq6kk5jc5tmhhxp7mvw55ct
12:40:51 wdconinc@menelaos ~ $ docker run --rm -it ghcr.io/eic/eic_ci:unstable-pr-35 bash -c 'du -sh /opt/software/linux-*/* | sort -h | tail'
107M    /opt/software/linux-x86_64_v2/py-onnxruntime-1.20.2-lbmybak3kpjfenan7hlkaa5cfbucquvi
109M    /opt/software/linux-x86_64_v2/py-scipy-1.16.3-nm6kr4k3sihewyppgl6km4tigh3ludc2
123M    /opt/software/linux-x86_64_v2/pythia8-8.315-oay5mm5eqxp4uo2mnordluyqc2yd773h
128M    /opt/software/linux-x86_64_v2/g4realsurface-2.2-7pbzz3kycww3u7airf7r42d22wpxhfhg
133M    /opt/software/linux-x86_64_v2/git-2.48.1-axbm7dgdq26ll6rxau3hime6empaxziu
229M    /opt/software/linux-x86_64_v2/boost-1.88.0-z2vdrl27s4eggbryokod33uzdhkhhnlw
247M    /opt/software/linux-x86_64_v2/geant4-11.3.2.east-h6wfkqo74qzznxkqz4lyysdztz6pi4w7
317M    /opt/software/linux-x86_64_v2/python-3.13.8-4j2apxg7wrlbznypmpsty56mfkfdyowv
645M    /opt/software/linux-x86_64_v2/root-6.38.00-hlln3yuyy5faqg3nkyvr3fu4f7mj6wdg
681M    /opt/software/linux-x86_64_v2/g4emlow-8.6.1-kwc7wum5crq6kk5jc5tmhhxp7mvw55ct

It seems we lost arrow... Arguably a good thing since I don't think we are using it :-)
ROOT is larger since the default for C++ modules was changed and pre-compiled C++20 modules are now installed to lib.

veprbl

LGTM
Thank you!

Copilot AI review requested due to automatic review settings November 15, 2025 00:49

Copilot started reviewing on behalf of wdconinc November 15, 2025 00:50 View session

Copilot finished reviewing on behalf of wdconinc November 15, 2025 01:00

Copilot AI reviewed Nov 15, 2025

View reviewed changes

wdconinc force-pushed the spack-packages-2025.11.0 branch 2 times, most recently from cdaa710 to 988a595 Compare November 20, 2025 16:37

Copilot AI review requested due to automatic review settings November 29, 2025 02:09

Copilot started reviewing on behalf of wdconinc November 29, 2025 02:09 View session

Copilot finished reviewing on behalf of wdconinc November 29, 2025 02:11

Copilot AI reviewed Nov 29, 2025

View reviewed changes

wdconinc force-pushed the spack-packages-2025.11.0 branch from e15ecfd to e41c9a6 Compare November 29, 2025 02:49

wdconinc mentioned this pull request Dec 25, 2025

feat: better resilience against listing already included cherry-picks #101

Merged

Copilot AI review requested due to automatic review settings December 25, 2025 16:51

Copilot started reviewing on behalf of wdconinc December 25, 2025 16:53 View session

Copilot AI reviewed Dec 25, 2025

View reviewed changes

wdconinc force-pushed the spack-packages-2025.11.0 branch from f2a976c to 0a605d2 Compare December 25, 2025 17:00

Copilot AI review requested due to automatic review settings December 25, 2025 18:05

wdconinc force-pushed the spack-packages-2025.11.0 branch from 0a605d2 to 1bb7d37 Compare December 25, 2025 18:05

Copilot started reviewing on behalf of wdconinc December 25, 2025 18:06 View session

Copilot AI reviewed Dec 25, 2025

View reviewed changes

containers/debian/Dockerfile Show resolved Hide resolved

containers/debian/Dockerfile Show resolved Hide resolved

wdconinc force-pushed the spack-packages-2025.11.0 branch from 1bb7d37 to d9dfd84 Compare December 25, 2025 18:30

Copilot AI review requested due to automatic review settings December 25, 2025 20:52

Copilot started reviewing on behalf of wdconinc December 25, 2025 20:53 View session

Copilot AI reviewed Dec 25, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings December 26, 2025 01:29

Copilot started reviewing on behalf of wdconinc December 26, 2025 01:29 View session

Copilot AI reviewed Dec 26, 2025

View reviewed changes

spack-packages.sh Show resolved Hide resolved

spack-environment/xl/spack.yaml Outdated Show resolved Hide resolved

spack-environment/packages.yaml Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings December 26, 2025 04:22

Copilot started reviewing on behalf of wdconinc December 26, 2025 04:22 View session

Copilot AI reviewed Dec 26, 2025

View reviewed changes

spack-environment/ci_without_acts/spack.yaml Outdated Show resolved Hide resolved

spack-environment/ci/spack.yaml Outdated Show resolved Hide resolved

spack-environment/cvmfs/spack.yaml Outdated Show resolved Hide resolved

wdconinc added 2 commits December 27, 2025 16:41

fix: spack cherry-pick: harfbuzz: Ensure consistent meson builder wit…

38de2ce

…h cairo dependency

fix: ci: concretizer: unify: when_possible

8e5ee67

Copilot AI review requested due to automatic review settings December 28, 2025 19:15

Copilot started reviewing on behalf of wdconinc December 28, 2025 19:15 View session

Copilot AI reviewed Dec 28, 2025

View reviewed changes

wdconinc added 3 commits December 28, 2025 13:57

fix: update SPACKPACKAGES_VERSION note on buildcache visibilty

cb55b62

fix: spack cherry-pick: harfbuzz/pango: add harfbuzz gobject variant …

40b79f1

…(& req for pango)

fix: harfbuzz: require: build_system=meson

c9f86ca

wdconinc force-pushed the spack-packages-2025.11.0 branch from 32a41af to c9f86ca Compare December 28, 2025 21:43

fix: allow spack gc to fail due to no-op

868c506

.

Copilot AI review requested due to automatic review settings December 29, 2025 03:59

Copilot started reviewing on behalf of wdconinc December 29, 2025 04:00 View session

Copilot AI reviewed Dec 29, 2025

View reviewed changes

wdconinc requested a review from veprbl December 29, 2025 04:09

wdconinc added 3 commits December 29, 2025 11:02

fix: packages: llvm: require: disable ipo requirements

9e52b75

Revert "fix: allow spack gc to fail due to no-op"

b06192e

This reverts commit 868c506.

fix: spack cherry-pick: openblas: patch for +dynamic_dispatch target=…

3d90277

…aarch64

Copilot AI review requested due to automatic review settings December 29, 2025 19:21

Copilot started reviewing on behalf of wdconinc December 29, 2025 19:22 View session

Copilot AI reviewed Dec 29, 2025

View reviewed changes

spack-environment/packages.yaml Show resolved Hide resolved

wdconinc added 2 commits December 29, 2025 23:04

fix: eic_cvmfs: concretizer: unify: when_possible

322c83f

fix: ci_without_acts: concretizer: unify: when_possible

b8cb9af

Copilot AI review requested due to automatic review settings December 30, 2025 13:42

Copilot started reviewing on behalf of wdconinc December 30, 2025 13:42 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

spack-environment/packages.yaml Show resolved Hide resolved

wdconinc enabled auto-merge (squash) December 30, 2025 16:18

wdconinc changed the title ~~Upgrade Spack Packages to v2025.11.0~~ chore: upgrade spack-packages to v2025.11.0 Dec 30, 2025

veprbl approved these changes Dec 31, 2025

View reviewed changes

wdconinc merged commit ec1edd8 into master Dec 31, 2025
34 checks passed

Conversation

wdconinc commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

wdconinc commented Dec 30, 2025

Uh oh!

veprbl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wdconinc commented Nov 15, 2025 •

edited

Loading